gtk4.git
11 years agoGtkMenuTracker: remove "visible" property
Ryan Lortie [Mon, 28 Apr 2014 08:12:25 +0000 (10:12 +0200)]
GtkMenuTracker: remove "visible" property

This is in conflict with the "is-visible" pseudo-property which is about
to be promoted to being an actual property.

11 years agoW32: Update the css to match the .modelbutton->.button.menuitem transition
Руслан Ижбулатов [Mon, 28 Apr 2014 15:51:51 +0000 (15:51 +0000)]
W32: Update the css to match the .modelbutton->.button.menuitem transition

11 years agoRename the modelbutton style class
Matthias Clasen [Sun, 27 Apr 2014 22:48:06 +0000 (18:48 -0400)]
Rename the modelbutton style class

This is not a great name to use in themes; instead, add the
menuitem class, so themes can use .button.menuitem for styles
that are specific to menuitem-like buttons.

11 years agoAdd a popover menu example to gtk3-widget-factory
Matthias Clasen [Sun, 27 Apr 2014 16:13:06 +0000 (12:13 -0400)]
Add a popover menu example to gtk3-widget-factory

11 years agoAdd a paned example to gtk3-widget-factory
Matthias Clasen [Sun, 27 Apr 2014 14:28:43 +0000 (10:28 -0400)]
Add a paned example to gtk3-widget-factory

11 years agoFix testmenubutton
Matthias Clasen [Sat, 26 Apr 2014 21:47:21 +0000 (17:47 -0400)]
Fix testmenubutton

The menu model examples was messing up the order of its items.

11 years agoGtkModelButton: improve size allocation
Matthias Clasen [Sat, 26 Apr 2014 20:37:16 +0000 (16:37 -0400)]
GtkModelButton: improve size allocation

Only reserve size for an indicator if at least one sibling
actually has an indicator.

11 years agoActually set the default for GtkMenuButton::use-popover
Matthias Clasen [Sat, 26 Apr 2014 18:40:52 +0000 (14:40 -0400)]
Actually set the default for GtkMenuButton::use-popover

The previous commit changed the property declaration, but
omitted the actual change of the default.

11 years agogdkscreen-wayland: Emit monitors-changed when the output scale changes
Adel Gadllah [Sat, 26 Apr 2014 12:08:51 +0000 (14:08 +0200)]
gdkscreen-wayland: Emit monitors-changed when the output scale changes

https://bugzilla.gnome.org/show_bug.cgi?id=729013

11 years agoAdd Adwaita to the list of default icon themes
Matthias Clasen [Sat, 26 Apr 2014 14:14:38 +0000 (10:14 -0400)]
Add Adwaita to the list of default icon themes

Hardcode the fallback to Adwaita. I'm leaving gnome in here for
now, since we're in the middle of the transition. It will be
removed before 3.14.

11 years agoFixed crash in GtkLockButton if a button with permission set to NULL is clicked.
Juan Pablo Ugarte [Fri, 25 Apr 2014 22:18:28 +0000 (19:18 -0300)]
Fixed crash in GtkLockButton if a button with permission set to NULL is clicked.

https://bugzilla.gnome.org/show_bug.cgi?id=728992

11 years agoGtkWindow: Avoid a critical in F10 handling
Matthias Clasen [Sat, 26 Apr 2014 02:07:13 +0000 (22:07 -0400)]
GtkWindow: Avoid a critical in F10 handling

The focus widget might be NULL, and we were forgetting to take
that possibility into account in one place.

11 years agotests: add missing files to EXTRA_DIST
Matthias Clasen [Thu, 24 Apr 2014 05:36:36 +0000 (01:36 -0400)]
tests: add missing files to EXTRA_DIST

https://bugzilla.gnome.org/show_bug.cgi?id=728846

11 years agoAdd missing templates to testdialog
Matthias Clasen [Thu, 24 Apr 2014 05:06:14 +0000 (01:06 -0400)]
Add missing templates to testdialog

This makes the template test cases not crash. The templates also
serve to test the new action widget support.

https://bugzilla.gnome.org/show_bug.cgi?id=728846

11 years agoGtkDialog: Update suggested-action more carefully
Matthias Clasen [Thu, 24 Apr 2014 05:32:50 +0000 (01:32 -0400)]
GtkDialog: Update suggested-action more carefully

We were not really handling all cases correctly here. We want
the suggested-action style class to only be set on headerbar
buttons, and it should be set on the default widget. Ensure
this by syncing the suggested-action style class with the
default style class. As a side-effect, setting has-default
on an action widget in ui files will now have the expected
effect.

https://bugzilla.gnome.org/show_bug.cgi?id=728846

11 years agoGtkDialog: Support adding action widgets in ui files
Matthias Clasen [Thu, 24 Apr 2014 04:28:13 +0000 (00:28 -0400)]
GtkDialog: Support adding action widgets in ui files

GtkDialog has convenience API for adding action widgets that are
either placed in the action area or the headerbar. This commit
makes the same functionality available from GtkBuilder ui files
by specifying "action" as the child type.

https://bugzilla.gnome.org/show_bug.cgi?id=728846

11 years agoopenbsd: properly set len for gtkmountoperation-x11
Antoine Jacoutot [Fri, 25 Apr 2014 12:37:59 +0000 (14:37 +0200)]
openbsd: properly set len for gtkmountoperation-x11

sysctl(3) is the correct way to get the lenght for len in this case.
Also drop unused headers and change style to match the rest of the file.

11 years agoGtkMenuButton: use popovers by default
Matthias Clasen [Fri, 25 Apr 2014 03:35:18 +0000 (23:35 -0400)]
GtkMenuButton: use popovers by default

When constructing from a menu model, use popovers by default.
This change has the potential to cause some size problems for
applications with big gear menus, so we're doing it early in
the cycle to uncover and fix those.

11 years agogdk/win32: VK_SNAPSHOT maps to GDK_Print
Marc-André Lureau [Mon, 15 Oct 2012 16:07:46 +0000 (18:07 +0200)]
gdk/win32: VK_SNAPSHOT maps to GDK_Print

Also, I am not sure the above VK_PRINT -> GDK_Print mapping is
correct, but it doesn't hurt yet.

https://bugzilla.gnome.org/show_bug.cgi?id=686170

11 years agowin32: add more clipboard data checks to avoid crash
Marc-André Lureau [Tue, 22 Apr 2014 17:47:47 +0000 (19:47 +0200)]
win32: add more clipboard data checks to avoid crash

It may happen that the received clipboard data is empty, but
if it's of type image/bmp, gtk+ will crash:

gdk_property_change: 00030AD4 GDK_SELECTION image/bmp REPLACE 8*0 bits:
... delayed rendering
gdk_selection_send_notify_for_display: 00030AD4 CLIPBOARD image/bmp
GDK_SELECTION (no-op)
_gdk_win32_selection_convert_to_dib: 1252003C image/bmp

Program received signal SIGSEGV, Segmentation fault.
0x749a9f40 in msvcrt!memmove () from C:\Windows\syswow64\msvcrt.dll

Thread 1 (Thread 2248.0x1b34):
target=0xc07b) at gdkselection-win32.c:1292
at gdkevents-win32.c:3498
wparam=8, lparam=0) at gdkevents-win32.c:232
message=773, wparam=8, lparam=0)
    at gdkevents-win32.c:263
C:\Windows\syswow64\user32.dll
C:\Users\rugoosse\AppData\Local\virt-viewer\bin\libpangocairo-1.0-0.dll
wparam=0, lparam=-1687549457)
    at gdkevents-win32.c:248
C:\Users\rugoosse\AppData\Local\virt-viewer\bin\libpangocairo-1.0-0.dll

https://bugzilla.gnome.org/show_bug.cgi?id=728745

11 years agoW32: Add modelbutton styles
Руслан Ижбулатов [Wed, 23 Apr 2014 16:10:33 +0000 (16:10 +0000)]
W32: Add modelbutton styles

According to what i've been told, modelbuttons are supposed to look
flat, like menu items.

This is basically an improved copy of the menuitem styles.

https://bugzilla.gnome.org/show_bug.cgi?id=728810

11 years agoW32: Add a set of "focused" styles to checkmarks
Руслан Ижбулатов [Wed, 23 Apr 2014 16:01:06 +0000 (16:01 +0000)]
W32: Add a set of "focused" styles to checkmarks

This prevents checkmarks in modelbuttons from being styled as buttons
(apparently, modelbuttons apply "focused" to their children, unlike
normal buttons).

https://bugzilla.gnome.org/show_bug.cgi?id=728808

11 years agoW32: Fix dummy prelight style for check/radio buttons
Руслан Ижбулатов [Wed, 23 Apr 2014 15:58:45 +0000 (15:58 +0000)]
W32: Fix dummy prelight style for check/radio buttons

Use a dummy transparent gradient instead of actual color (which screws up
focus rectangle on prelight), and apply to non-prelight state as well.

https://bugzilla.gnome.org/show_bug.cgi?id=728807

11 years agoW32: remove the blue "selected" rectangle when activating a checkbutton
Руслан Ижбулатов [Wed, 23 Apr 2014 15:57:24 +0000 (15:57 +0000)]
W32: remove the blue "selected" rectangle when activating a checkbutton

https://bugzilla.gnome.org/show_bug.cgi?id=728806

11 years agoAdd all version macros to the docs
Matthias Clasen [Thu, 24 Apr 2014 03:25:30 +0000 (23:25 -0400)]
Add all version macros to the docs

11 years agoAdd GDK_VERSION_3_14
Matthias Clasen [Thu, 24 Apr 2014 03:25:07 +0000 (23:25 -0400)]
Add GDK_VERSION_3_14

https://bugzilla.gnome.org/show_bug.cgi?id=728814

11 years agoUpdated Hebrew translation
Yosef Or Boczko [Wed, 23 Apr 2014 09:50:51 +0000 (12:50 +0300)]
Updated Hebrew translation

11 years agodialog: keep action area stretched out
Matthias Clasen [Wed, 23 Apr 2014 04:05:15 +0000 (00:05 -0400)]
dialog: keep action area stretched out

Adding an extra box in between had the side effect of
making the action area no longer go all across the dialog.
Setting hexpand compensates for this.

11 years agowayland: handle the wl_touch interface
Carlos Garnacho [Thu, 17 Apr 2014 12:19:39 +0000 (14:19 +0200)]
wayland: handle the wl_touch interface

The events are routed through a new slave device with type
GDK_SOURCE_TOUCHSCREEN, minimal tracking of touches is done
to keep the state for each of those.

https://bugzilla.gnome.org/show_bug.cgi?id=728426

11 years agowayland: Separate master devices from seat capabilities
Carlos Garnacho [Thu, 17 Apr 2014 11:15:08 +0000 (13:15 +0200)]
wayland: Separate master devices from seat capabilities

The master pointer/keyboard pair should never disappear or be
inconsistent. The seat capabilities are now reflected through
slave devices, those may come and go freely as the seat
capabilities change. This also enables adding further capabilities
to handle eg. touch.

https://bugzilla.gnome.org/show_bug.cgi?id=728426

11 years agoDND: go back to a timeout for cancel animation
Matthias Clasen [Tue, 15 Apr 2014 00:10:25 +0000 (17:10 -0700)]
DND: go back to a timeout for cancel animation

Using a tick callback does not really make sense here, since we
are not drawing in a window, but moving a toplevel around.
https://bugzilla.gnome.org/show_bug.cgi?id=728183

11 years agoGtkFileChooserDialog: Avoid a bottom border in the dialog
Matthias Clasen [Wed, 23 Apr 2014 03:08:43 +0000 (23:08 -0400)]
GtkFileChooserDialog: Avoid a bottom border in the dialog

We recently started to respect border-width on the action_area
again, so set its border-width to 0 so it doesn't get in the way.

https://bugzilla.gnome.org/show_bug.cgi?id=722211

11 years agodialog: add a box around the action area to use for styling
William Jon McCann [Wed, 9 Apr 2014 18:30:37 +0000 (14:30 -0400)]
dialog: add a box around the action area to use for styling

If we want to set style properties that include the area
of the border-width part of action_area we need to use a
parent box.

https://bugzilla.gnome.org/show_bug.cgi?id=722211

11 years agofile-chooser: make enter location an operation mode
William Jon McCann [Wed, 9 Apr 2014 17:49:54 +0000 (13:49 -0400)]
file-chooser: make enter location an operation mode

https://bugzilla.gnome.org/show_bug.cgi?id=722211

11 years agofile-chooser: merge path bar mode and location mode
William Jon McCann [Wed, 9 Apr 2014 16:18:37 +0000 (12:18 -0400)]
file-chooser: merge path bar mode and location mode

https://bugzilla.gnome.org/show_bug.cgi?id=722211

11 years agofile-chooser: remove select a folder info message
William Jon McCann [Wed, 9 Apr 2014 16:00:08 +0000 (12:00 -0400)]
file-chooser: remove select a folder info message

https://bugzilla.gnome.org/show_bug.cgi?id=722211

11 years agofile-chooser: don't use an special label for recent
William Jon McCann [Wed, 9 Apr 2014 15:50:42 +0000 (11:50 -0400)]
file-chooser: don't use an special label for recent

https://bugzilla.gnome.org/show_bug.cgi?id=722211

11 years agofile-chooser: add a search bar instead of using a path bar mode
William Jon McCann [Wed, 9 Apr 2014 15:47:07 +0000 (11:47 -0400)]
file-chooser: add a search bar instead of using a path bar mode

https://bugzilla.gnome.org/show_bug.cgi?id=722211

11 years agofile-chooser: add sidebar class to sidebar
William Jon McCann [Wed, 9 Apr 2014 14:54:00 +0000 (10:54 -0400)]
file-chooser: add sidebar class to sidebar

https://bugzilla.gnome.org/show_bug.cgi?id=722211

11 years agofile-chooser: style location bar as a search bar
William Jon McCann [Tue, 8 Apr 2014 17:29:01 +0000 (13:29 -0400)]
file-chooser: style location bar as a search bar

So we get a nice bottom border etc.

https://bugzilla.gnome.org/show_bug.cgi?id=722211

11 years agofile-chooser: style save mode name box as a search bar
William Jon McCann [Tue, 8 Apr 2014 17:26:08 +0000 (13:26 -0400)]
file-chooser: style save mode name box as a search bar

So we get a bottom border etc.

https://bugzilla.gnome.org/show_bug.cgi?id=722211

11 years agofile-chooser: don't show a "save folder:" label
William Jon McCann [Tue, 8 Apr 2014 17:21:38 +0000 (13:21 -0400)]
file-chooser: don't show a "save folder:" label

https://bugzilla.gnome.org/show_bug.cgi?id=722211

11 years agofile-chooser: move location entry into same place as pathbar
William Jon McCann [Tue, 8 Apr 2014 17:13:01 +0000 (13:13 -0400)]
file-chooser: move location entry into same place as pathbar

https://bugzilla.gnome.org/show_bug.cgi?id=722211

11 years agoplaces-sidebar: add optional enter location place
William Jon McCann [Mon, 7 Apr 2014 22:43:28 +0000 (18:43 -0400)]
places-sidebar: add optional enter location place

https://bugzilla.gnome.org/show_bug.cgi?id=722211

11 years agofile-chooser: no shadow on scrolled window
William Jon McCann [Mon, 7 Apr 2014 21:55:08 +0000 (17:55 -0400)]
file-chooser: no shadow on scrolled window

https://bugzilla.gnome.org/show_bug.cgi?id=722211

11 years agofile-chooser: use an action bar for extra widgets area
William Jon McCann [Mon, 7 Apr 2014 21:52:20 +0000 (17:52 -0400)]
file-chooser: use an action bar for extra widgets area

https://bugzilla.gnome.org/show_bug.cgi?id=722211

11 years agofile-chooser: allow views to extend to the sides of the dialog
William Jon McCann [Mon, 7 Apr 2014 21:18:56 +0000 (17:18 -0400)]
file-chooser: allow views to extend to the sides of the dialog

https://bugzilla.gnome.org/show_bug.cgi?id=722211

11 years agofile-chooser: move filter combo into extra area
William Jon McCann [Mon, 7 Apr 2014 19:57:19 +0000 (15:57 -0400)]
file-chooser: move filter combo into extra area

https://bugzilla.gnome.org/show_bug.cgi?id=722211

11 years agofile-chooser: move pathbar into preview pane
William Jon McCann [Mon, 7 Apr 2014 19:16:21 +0000 (15:16 -0400)]
file-chooser: move pathbar into preview pane

https://bugzilla.gnome.org/show_bug.cgi?id=722211

11 years agoplaces-sidebar: use separators instead of heading labels
William Jon McCann [Mon, 7 Apr 2014 19:00:01 +0000 (15:00 -0400)]
places-sidebar: use separators instead of heading labels

https://bugzilla.gnome.org/show_bug.cgi?id=722211

11 years agoGet rid of a stray character
Jason Ekstrand [Wed, 23 Apr 2014 02:17:55 +0000 (21:17 -0500)]
Get rid of a stray character

11 years agocsd: Fix drag hightlight drawing
Matthias Clasen [Wed, 23 Apr 2014 01:19:21 +0000 (21:19 -0400)]
csd: Fix drag hightlight drawing

When making the entire window a drop target, as file-roller does,
we don't want to draw the drag highlight around the CSD window
decorations.
https://bugzilla.gnome.org/show_bug.cgi?id=728526
 Please enter the commit message for your changes. Lines starting

11 years agoAllow defining an invisible resize area for GtkPaned's handle.
Victor Martinez [Sat, 12 Apr 2014 02:50:48 +0000 (20:50 -0600)]
Allow defining an invisible resize area for GtkPaned's handle.

This should allow theme developers to use a very small width for
the resize handle, but still let users easily move the handle by
defining a wider resize area.

The additional resize area follows the "margin" style property.

https://bugzilla.gnome.org/show_bug.cgi?id=728073

11 years agowayland: Map the window immediately on show
Jasper St. Pierre [Tue, 22 Apr 2014 23:16:48 +0000 (19:16 -0400)]
wayland: Map the window immediately on show

11 years agowayland: Remove useless hint set
Jasper St. Pierre [Tue, 22 Apr 2014 23:16:26 +0000 (19:16 -0400)]
wayland: Remove useless hint set

11 years agowayland: Remove VISIBILITY_NOTIFY event
Jasper St. Pierre [Tue, 22 Apr 2014 23:14:55 +0000 (19:14 -0400)]
wayland: Remove VISIBILITY_NOTIFY event

VISIBILITY_NOTIFY is already known to be unreliable.

11 years agogtk-demo: Make sure to clear the timeout when we stop it
Jasper St. Pierre [Sat, 12 Apr 2014 17:35:19 +0000 (10:35 -0700)]
gtk-demo: Make sure to clear the timeout when we stop it

11 years agoGtkScaleButton: Don't specify a icon size of zero
Matthias Clasen [Tue, 22 Apr 2014 22:34:35 +0000 (18:34 -0400)]
GtkScaleButton: Don't specify a icon size of zero

This only works for scalable icons, but breaks if we fall
back to pngs.

11 years agoFix the build
Matthias Clasen [Tue, 22 Apr 2014 15:08:17 +0000 (11:08 -0400)]
Fix the build

11 years agoAdd a style class to model buttons
Matthias Clasen [Tue, 22 Apr 2014 15:04:40 +0000 (11:04 -0400)]
Add a style class to model buttons

This will let us stop using the class name in Adwaita, and will
help with some future additions.

11 years agodocs: Fix parameter names for two functions
Volker Sobek [Mon, 21 Apr 2014 20:57:35 +0000 (22:57 +0200)]
docs: Fix parameter names for two functions

Don't use two different parameter names.

11 years agoFixed Russian translation
Yuri Myasoedov [Sun, 20 Apr 2014 11:18:10 +0000 (15:18 +0400)]
Fixed Russian translation

11 years agoUpdated German translation
Christian Kirbach [Sat, 19 Apr 2014 11:58:38 +0000 (11:58 +0000)]
Updated German translation

11 years agoAdded bindings support to GtkBuilder by introducing 3 new <property> attributes ...
Juan Pablo Ugarte [Fri, 11 Apr 2014 19:24:04 +0000 (16:24 -0300)]
Added bindings support to GtkBuilder by introducing 3 new <property> attributes "bind-source" to specify the source object of the binding "bind-property" to specify the source property and "bind-flags" to specify the binding flags (optional)

Binding an object sensitive property with a check button active property will look like this:

<object class="GtkButton" id="button">
  <property name="sensitive" bind-source="checkbutton" bind-property="active"/>
</object>

This is based on the original work done by Denis Washington for his GSoC project

This closes Bug 654417 "[GSoC] Add <binding> element to GtkBuilder syntax"

11 years agobroadway backend: allow building on OpenBSD
Antoine Jacoutot [Thu, 17 Apr 2014 22:59:45 +0000 (00:59 +0200)]
broadway backend: allow building on OpenBSD

On OpenBSD shm_open(3) is part of libc and there is not librt, so add an
according check.
Check if we have posix_fallocate before using it.

https://bugzilla.gnome.org/show_bug.cgi?id=728272

11 years agoexample: Update screenshots
Matthias Clasen [Thu, 17 Apr 2014 20:18:35 +0000 (13:18 -0700)]
example: Update screenshots

11 years agoexample: Use popover for gears menu
Matthias Clasen [Thu, 17 Apr 2014 19:43:17 +0000 (12:43 -0700)]
example: Use popover for gears menu

11 years agoexample: Make gears button square
Matthias Clasen [Thu, 17 Apr 2014 19:39:07 +0000 (12:39 -0700)]
example: Make gears button square

Another application of image-button.

11 years agoexample: Make search button square
Matthias Clasen [Thu, 17 Apr 2014 19:37:51 +0000 (12:37 -0700)]
example: Make search button square

The image-button style class takes care of it.

11 years agoexample: Modernize the prefs dialog
Matthias Clasen [Thu, 17 Apr 2014 19:18:01 +0000 (12:18 -0700)]
example: Modernize the prefs dialog

We should show the current best practice for this kind of
dialog, and use a headerbar with a window close button.

11 years agoexample: Port to gtk_application_set_accels_for_action
Matthias Clasen [Thu, 17 Apr 2014 18:36:33 +0000 (11:36 -0700)]
example: Port to gtk_application_set_accels_for_action

Instead of hardcoding an accelerator in the ui file, use
gtk_application_set_accels_for_action.

11 years agoexample: Fix indentation
Matthias Clasen [Thu, 17 Apr 2014 18:27:11 +0000 (11:27 -0700)]
example: Fix indentation

11 years agoexample: Fix up margins
Matthias Clasen [Thu, 17 Apr 2014 18:11:17 +0000 (11:11 -0700)]
example: Fix up margins

This makes the code match what we show in the screenshots. This
broke when headerbars were changed to allow titles to extend into
the margin.

11 years agoexample: Don't set a nonexisting property
Matthias Clasen [Thu, 17 Apr 2014 17:52:50 +0000 (10:52 -0700)]
example: Don't set a nonexisting property

The GtkHeaderBar::show-fallback-app-menu property does not exist,
and isn't needed anyway.

11 years agowayland: The xdg_surface.delete event was renamed to close
Jasper St. Pierre [Thu, 17 Apr 2014 17:14:44 +0000 (13:14 -0400)]
wayland: The xdg_surface.delete event was renamed to close

11 years agoW32: correctly guess max window size from the size of the workarea of the screen...
Руслан Ижбулатов [Thu, 10 Apr 2014 20:05:19 +0000 (20:05 +0000)]
W32: correctly guess max window size from the size of the workarea of the screen it's on

Get monitor on which the most of the window is located (nearest monitor if
window is not on screen), get its work area (area not occupied by taskbar or
any other bars) and use that for maxsize.

Previous default of 30000 meant that windows maximized onto full screen,
even covering the area where taskbar is.

https://bugzilla.gnome.org/show_bug.cgi?id=726592

11 years agoselection: mark targets param to gtk_target_list_new as allow-none
Evan Nemerson [Mon, 14 Apr 2014 09:26:51 +0000 (02:26 -0700)]
selection: mark targets param to gtk_target_list_new as allow-none

https://bugzilla.gnome.org/show_bug.cgi?id=728165

11 years agogtkapplication: Fix incorrect value passed to g_variant_new()
Bastien Nocera [Mon, 14 Apr 2014 14:40:20 +0000 (16:40 +0200)]
gtkapplication: Fix incorrect value passed to g_variant_new()

The code expected to format @u, not u.

https://bugzilla.gnome.org/show_bug.cgi?id=728140

11 years agoiconhelper: always ensure a stated pixbuf
Cosimo Cecchi [Sun, 4 Aug 2013 14:50:31 +0000 (16:50 +0200)]
iconhelper: always ensure a stated pixbuf

Even when we are set a pixbuf itself.

https://bugzilla.gnome.org/show_bug.cgi?id=726271

11 years agoGtkColorChooserWidget: Redraw swatches when selection changes
Marcus Karlsson [Sat, 12 Apr 2014 08:09:46 +0000 (10:09 +0200)]
GtkColorChooserWidget: Redraw swatches when selection changes

When selecting a swatch in a GtkColorChooserWidget the previously
selected swatch and the currently selected swatch are not redrawn. This
can leave the old swatch still marked with a checkbox even though a new
swatch has been selected.

Redraw the swatches after changing the selection.

https://bugzilla.gnome.org/show_bug.cgi?id=727487

11 years agodocs: fix GtkWidget::size-allocate description
Marcus Karlsson [Tue, 8 Apr 2014 20:40:01 +0000 (22:40 +0200)]
docs: fix GtkWidget::size-allocate description

The documentation for the GtkWidget::size-allocate signal is missing the
description of the "allocation" parameter. Add the missing description
to the parameter.

https://bugzilla.gnome.org/show_bug.cgi?id=726179

11 years agoGtkTextView: use GSlice to allocate GtkTextLineSegment's
Sébastien Wilmet [Fri, 11 Apr 2014 15:45:50 +0000 (17:45 +0200)]
GtkTextView: use GSlice to allocate GtkTextLineSegment's

Use GSlice to allocate all types of segments:
- char
- toggle
- mark
- pixbuf
- child widget

Char segments are a bit more complicated because the length of the text
is determined at run time and stored in the 'byte_count' field. If the
text is long, GSlice will call the system malloc() anyway, so it's
better to always use GSlice for GtkTextLineSegment.

Toggle segments are also freed in gtktextbtree.c, hence the function
_gtk_toggle_segment_free() (for a later commit it would be nice to
rename those functions with the _gtk_text prefix).

https://bugzilla.gnome.org/show_bug.cgi?id=727908

11 years agotextview: inline a function
Sébastien Wilmet [Wed, 9 Apr 2014 14:53:14 +0000 (16:53 +0200)]
textview: inline a function

gtk_text_view_move_cursor_internal() was exactly the same as
gtk_text_view_move_cursor(), and was called only in the latter function.

https://bugzilla.gnome.org/show_bug.cgi?id=727908

11 years agodoc: improve documentation of gtk_text_iter_inside_word()
Sébastien Wilmet [Tue, 8 Apr 2014 20:43:25 +0000 (22:43 +0200)]
doc: improve documentation of gtk_text_iter_inside_word()

There is a possible confusion with the sentence:
"@iter is inside a natural-language word"

The iter should be viewed here as the pointed character (i.e. on the
right of the iter), not as a position between two characters.

Instead of improving the documentation, another solution would have been
to change the implementation so it is interpreted as an iter position
inside a word, i.e. between two characters that are part of a
natural-language word. But maybe some applications rely on the current
implementation.

https://bugzilla.gnome.org/show_bug.cgi?id=727908

11 years agotests textiter: test word boundaries
Sébastien Wilmet [Tue, 8 Apr 2014 19:36:45 +0000 (21:36 +0200)]
tests textiter: test word boundaries

- As the tests show, some of the functions have a strange and
inconsistent behavior for corner cases.

- Rename test_full_buffer() -> test_search_full_buffer() because
textiter.c is used for other GtkTextIter unit tests.

https://bugzilla.gnome.org/show_bug.cgi?id=727908

11 years agolistbox: Add tests for multi-selection
Matthias Clasen [Sun, 13 Apr 2014 21:03:12 +0000 (14:03 -0700)]
listbox: Add tests for multi-selection

This was forgotten when the multi-selection API was added,
and it was promptly broken in some places.

11 years agolist-box: Fix copy-paste error
Matthias Clasen [Sun, 13 Apr 2014 20:55:28 +0000 (13:55 -0700)]
list-box: Fix copy-paste error

The new function gtk_list_box_get_selected_rows was implemented
as gtk_list_box_get_selected_children.

11 years agolistbox: Emit ::row-selected as we used to
Matthias Clasen [Sun, 13 Apr 2014 20:51:49 +0000 (13:51 -0700)]
listbox: Emit ::row-selected as we used to

The listbox selection test was failing because we were not
emitting these signals anymore.

11 years agodocs: Add missing transfer annotation to GtkBox
Marcus Karlsson [Sat, 12 Apr 2014 18:22:15 +0000 (20:22 +0200)]
docs: Add missing transfer annotation to GtkBox

The gtk_box_get_center_widget function is missing a transfer annotation
for the returned widget. No transfer is done, so set transfer to none.

https://bugzilla.gnome.org/show_bug.cgi?id=728093

11 years agogtk-demo: Avoid a compiler warning
Matthias Clasen [Sun, 13 Apr 2014 05:13:40 +0000 (22:13 -0700)]
gtk-demo: Avoid a compiler warning

11 years agowidget-factory: Clean up on shutdown
Matthias Clasen [Sun, 13 Apr 2014 05:13:14 +0000 (22:13 -0700)]
widget-factory: Clean up on shutdown

11 years agowidget-factory: Remove unnecessary signal handlers
Matthias Clasen [Sun, 13 Apr 2014 05:12:38 +0000 (22:12 -0700)]
widget-factory: Remove unnecessary signal handlers

quitting the mainloop when none is running gives a critical
warning on shutdown.

11 years agowidget-factory: Add a listbox example
Matthias Clasen [Sun, 13 Apr 2014 04:45:30 +0000 (21:45 -0700)]
widget-factory: Add a listbox example

11 years agowidget-factory: Improve actionbar appearance
Matthias Clasen [Sun, 13 Apr 2014 04:09:03 +0000 (21:09 -0700)]
widget-factory: Improve actionbar appearance

We are using the actionbar in the middle of the window, which
is not really what it is designed for. To avoid the unfinished
appearance on the sides, move it into the frame that we have
around the stack below. This fixes the sides, but gives the top
a double stroke. Too bad.

11 years agowidget-factory: Avoid ugly resizing on map
Matthias Clasen [Sun, 13 Apr 2014 03:46:17 +0000 (20:46 -0700)]
widget-factory: Avoid ugly resizing on map

The text view is resizing several times after the window is mapped.
Not setting a hscrollbar-policy of never avoids that, and a
scrollbar still doesn't appear. Magic

11 years agogtk-demo: Fix images demo
Matthias Clasen [Sun, 13 Apr 2014 03:39:26 +0000 (20:39 -0700)]
gtk-demo: Fix images demo

The incremental loading was broken by GtkIconHelper - queuing a
redraw is no longer sufficient to cause GtkImage to redraw with
the new pixbuf contents.
Pointed out by Jasper St. Pierre.

11 years agogtk-demo: Fix the links example
Matthias Clasen [Sun, 13 Apr 2014 01:42:29 +0000 (18:42 -0700)]
gtk-demo: Fix the links example

The keynav dialog is transient to the example window; since the
example window is now modal, we need to make the keynav dialog
modal as well, so it can receive input.
Problem pointed out by Jasper St. Pierre.

11 years agoRemove gdk_synthesize_window_state from gdkinternals.h
Jasper St. Pierre [Sat, 12 Apr 2014 00:02:45 +0000 (17:02 -0700)]
Remove gdk_synthesize_window_state from gdkinternals.h

It's already in gdkprivate.h

11 years agowayland: set_transient_for was renamed to set_parent
Jasper St. Pierre [Fri, 11 Apr 2014 23:55:37 +0000 (16:55 -0700)]
wayland: set_transient_for was renamed to set_parent

11 years agowayland: Don't pass dx/dy when we're resizing
Jasper St. Pierre [Fri, 11 Apr 2014 23:53:05 +0000 (16:53 -0700)]
wayland: Don't pass dx/dy when we're resizing

They're ignored by the server.